#25878: APPEND_SLASH doesn't work with DEBUG=False when template/404.html is
erroneous
---------------------------------+-------------------------------------
Reporter: kuna | Owner: timgraham
Type: Bug | Status: assigned
Component: HTTP handling | Version: 1.9
Severity: Release blocker | Resolution:
Keywords: slash,debug | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+-------------------------------------
Comment (by timgraham):
Thanks for that info. At this point then, I'm inclined to discard my
initial patch and instead add a mention in the release notes about this as
well as to try to improve the error reporting situation. To address the
situation in comment 18, an idea is to log a warning in
[https://github.com/django/django/blob/98839e906632dfe77c6f6906d61d62868a0541dc/django/core/handlers/base.py#L86-L93
BaseHander.get_exception_response()] if the error handler returns a
response with the incorrect status code. I haven't thought through if
there could be a valid reason for returning a different code, but
automatically setting the code could be a bit risky for a patch that's
backported to a stable branch. I'll have to look to see if we can do any
better about the situation where the 404 template doesn't render correctly
as reported in the ticket description.
--
Ticket URL: <https://code.djangoproject.com/ticket/25878#comment:19>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/062.0b3e9fbad6b8a2a74faed6b55995243a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
