#26007: SingleObjectTemplateResponseMixin.get_template_names does not return 
names
stack properly.
-------------------------------+------------------------------------
     Reporter:  chmarr         |                    Owner:  chmarr
         Type:  Bug            |                   Status:  assigned
    Component:  Generic views  |                  Version:  1.9
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  1              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------

Comment (by chmarr):

 Note: This patch introduces one potential backwards incompatibility:

 In the current code, if both template_name and template_field_name is set,
 template_field_name is always ignored. With the patch, if
 template_field_name is declared AND there is a non-empty value in the
 referenced field, the template name from the field is used in preference
 to template_name.

 I think the patch implements the intended behaviour (or why bother trying
 to `insert(0, name)`), and cases were someone has set both template_name
 and template_field_name is rare or non-existant, but given this
 possibility, we may want to defer the change to 1.10 with or without
 accelerated deprecation. Advise?

--
Ticket URL: <https://code.djangoproject.com/ticket/26007#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c417e6a76437168f428d95b656047b0f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to