#26006: SingleObjectMixin.get_context_object_name refers to obj and self.object
inconsistently
--------------------------------------+------------------------------------
     Reporter:  chmarr                |                    Owner:  chmarr
         Type:  Cleanup/optimization  |                   Status:  assigned
    Component:  Generic views         |                  Version:  master
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  0
  Needs tests:  1                     |  Patch needs improvement:  1
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by charettes):

 * needs_better_patch:  0 => 1
 * version:  1.9 => master
 * needs_tests:  0 => 1


Comment:

 The change makes sense.

 This should be good to go once you add a regression test or adjust
 
[https://github.com/chmarr/django/commit/86aaffa5a3510c007167d116cf4ad72b79e93f31
 the ones added by this check].

--
Ticket URL: <https://code.djangoproject.com/ticket/26006#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.5d310daf6b266b21b2816a44079d165c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to