#25953: Add from_db_value() support to 
django.contrib.postgres.fields.ArrayField.
-------------------------------------+-------------------------------------
     Reporter:  karanlyons           |                    Owner:
         Type:  Bug                  |                   Status:  new
    Component:  contrib.postgres     |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:  ArrayField,          |             Triage Stage:  Accepted
  from_db_value                      |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  1                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by charettes):

 * version:  1.9 => master
 * needs_tests:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Makes sense to me but this will need additional tests to get merged.

 If you could submit your patch as Github PR it would also give it more
 visibility and help reviewers run CI against it.

 Concerning the implementation I think you should avoid creating a local
 function to attach it as a method but declare a `_from_db_value` method
 that you assign to `from_db_value` instead.

--
Ticket URL: <https://code.djangoproject.com/ticket/25953#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.1972865c419bccc1716bbfc4a0e11f9d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to