#25845: False timezone offset warnings in admin if a custom base template
doesn't
set data-admin-utc-offset
-------------------------------+--------------------------------------
Reporter: Strayer | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Comment (by Strayer):
But wasn't the old behavior to not show the warnings if the JavaScript
attribute is missing? As far as I can see, django-suit also didn't set the
window property !__admin_utc_offset!__ before. The warnings were not
shown, since the JS function addTimezoneWarning() won't do anything if
timezoneOffset is not set. The whole check on undefined doesn't make sense
to me and looks like a leftover of the previous code.
If the checks were to be replaced by a check on null (and possibly ""), it
would behave like before.
--
Ticket URL: <https://code.djangoproject.com/ticket/25845#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.c4be04c389ac89c1deff53efd9f5a70b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
