#25687: Document how backends should monkey patch expressions
-------------------------------------+-------------------------------------
Reporter: jarshwah | Owner:
Type: | kristofclaes
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by carljm):
After discussion with jarshwah and manfre, we've agreed that none of us
really care that much between simple monkeypatching vs a public API that
does the monkeypatching internally. I don't think there's any practical
benefit to the public API, even in terms of future flexibility: either way
we're committed to the `as_vendor` method system, whether the method gets
there via monkeypatching or otherwise is irrelevant. The only real benefit
is that recommending monkeypatching in our documentation looks bad :-)
I think this doc patch should go ahead as-is. If I (or dedsm or anyone
else) is motivated enough to submit a PR that adds the three-line public
API (could also be a decorator) and modifies the docs accordingly, it
would likely be accepted.
--
Ticket URL: <https://code.djangoproject.com/ticket/25687#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.b92b46bc5e922a04bef78e13e3ed0ba8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
