#25611: Use a common descriptor signature
------------------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
Currently we have [https://github.com/django/django/pull/5226 several
different signatures] for descriptor methods `__get__()` and `__set__()`:
Curtis proposed:
* "instance_type" is explicit
* "cls" is a common convention for passing a class
* "owner" is in the docs {but so are others}
* and "type" I think is a bit confusing...
So... my preference, upon reflection, would be: `def __get__(self,
instance, cls=None)`
This got several +1s [https://groups.google.com/forum/#!topic/django-
developers/3eSHhZUzxv4 on the mailing list].
--
Ticket URL: <https://code.djangoproject.com/ticket/25611>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.5b8c5fd15dc0642b509322bb0d44bc1d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
