#25395: Add an optional dependency on python-fastpbkdf2
-------------------------------------+-------------------------------------
Reporter: Ayrx | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Ayrx):
Replying to [comment:1 timgraham]:
> Are your improvements suitable for inclusion in Python itself? It seems
better to pursue that course of action to me. My initial reaction is
reluctance to add a dependency in a security sensitive area, especially
for a project which is only 1 month old. You can write to the
DevelopersMailingList to get more feedback.
I'm not sure if it's suitable for inclusions into Python itself as I'm not
a core dev. Even if it is, it won't benefit Python 2.7 or PyPy users (who
gains the most from this library).
I understand the hesitation to add a dependency on a new project. If it's
any help, I take test coverage very seriously and the project is currently
at 100% coverage and are tested against the standard PBKDF2 vectors. The
bindings rely on CFFI which is what the bcrypt dependency also currently
using. The [https://github.com/ctz/fastpbkdf2/blob/master/fastpbkdf2.c C
library] itself about 400 or so lines of pretty readable C if anyone would
like to review it.
I'll write to the list seeking further feedback in a few days.
--
Ticket URL: <https://code.djangoproject.com/ticket/25395#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/062.8281206730b35b60aa72e23fe95d62fd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
