#25064: Join.as_sql() emits invalid SQL if get_joining_columns() returns an
empty
tuple
-------------------------------------+-------------------------------------
Reporter: AlexHill | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 1.8
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by AlexHill):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Old description:
> If you override `get_joining_columns()` to return an empty tuple but
> provide extra conditions with `extra_join_restrictions()` ,
> `Join.as_sql()` creates invalid SQL.
New description:
`Join.as_sql()` gets its join conditions from two places: the
`get_joining_columns()` and `get_extra_restrictions()`.
The SQL for extra restrictions is unconditionally prefixed with `AND`,
which means invalid SQL is emitted if no joining columns are specified.
The fix to make the `AND` conditional is a one-liner and allows users to
override the default join conditions instead of adding to them.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/25064#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.22559f825a78c4d1299056c3b7422cd0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
