#25053: Admin: Password help_text only uses "safe" filter when adding a user
-------------------------------+-------------------------------------
     Reporter:  ataylor32      |      Owner:  nobody
         Type:  Bug            |     Status:  new
    Component:  contrib.admin  |    Version:  1.8
     Severity:  Normal         |   Keywords:  password help_text safe
 Triage Stage:  Unreviewed     |  Has patch:  0
Easy pickings:  1              |      UI/UX:  0
-------------------------------+-------------------------------------
 The "admin/auth/user/add_form.html" template extends
 "admin/change_form.html", which uses "admin/includes/fieldset.html", which
 displays help_text using the "safe" filter:

 {{ field.field.help_text|safe }}

 The "admin/auth/user/change_password.html" template, on the other hand,
 displays help_text without using the "safe" filter:

 {{ form.password1.help_text }}
 {{ form.password2.help_text }}

 Same with the "registration/password_change_form.html" template:

 {{ form.new_password1.help_text }}
 {{ form.new_password2.help_text }}

 Thus, if either password field has help_text with HTML, it will only
 display correctly when adding a user.

 I will be submitting a pull request soon.

--
Ticket URL: <https://code.djangoproject.com/ticket/25053>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.264c6d81e0b023520e273fcee2ccaf8e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to