#24803: Collected SQL does not respect empty strings as params when formatting
result sql
-------------------------------------+-------------------------------------
     Reporter:  coldmind             |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by dukebody):

 @coldmind, I have this issue with MySQL and the MySQL engine doesn't have
 `features.requires_literal_defaults=True`, so that code doesn't get
 executed. Tested placing a pdb there.

 Apparently MySQLdb quotes bytestrings when escaping, but not unicode
 strings: http://sourceforge.net/p/mysql-
 
python/mysqldb-2/ci/7773efbe9b3012da2827b0284c43267cc9a4ecbd/tree/MySQLdb/converters.py


 {{{
 def unicode_to_sql(value, conv):
     """Convert a unicode object to a string using the default encoding.
     This is only used as a placeholder for the real function, which
     is connection-dependent."""
     assert isinstance(value, unicode)
     return value.encode()
 }}}

 Could the placeholder comment mean that some connection parameters should
 convert the unicode string to a bytestring and then quote it?

--
Ticket URL: <https://code.djangoproject.com/ticket/24803#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1f829af7078fd1869b8065bd26f9d705%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to