#24737: Unnecesary kwarg passed in UserManager's _create_user
----------------------------------------------+--------------------
     Reporter:  delgiudices                   |      Owner:  nobody
         Type:  Uncategorized                 |     Status:  new
    Component:  Database layer (models, ORM)  |    Version:  1.8
     Severity:  Normal                        |   Keywords:
 Triage Stage:  Unreviewed                    |  Has patch:  0
Easy pickings:  0                             |      UI/UX:  0
----------------------------------------------+--------------------
 From {{{django/contrib/auth/models.py}}}

 {{{
 user = self.model(username=username, email=email,
                           is_staff=is_staff, is_active=True,
                           is_superuser=is_superuser,
                           date_joined=now, **extra_fields)
 }}}
 date_joined is being specified but in the model declaration ( line 406 )
 date_joined is set to now by default.
 {{{406: date_joined = models.DateTimeField(_('date joined'),
 default=timezone.now }}}

 I've removed the date_joined kwarg and all tests were ok. I've pushed what
 i think is the solution here:
 
[https://github.com/delgiudices/django/blob/test_user/django/contrib/auth/models.py#L178]

--
Ticket URL: <https://code.djangoproject.com/ticket/24737>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/054.b94865fc60eaf69f9d02ca3e256eb036%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to