#24702: Cache Query objects when possible
-------------------------------------+-------------------------------------
     Reporter:  thedrow              |                    Owner:  nobody
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  Database layer       |                  Version:  1.8
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by shaib):

 Haven't looked in the tests code, so I can only guess that the tests fail
 because you're getting the memoized "all" query instead of one that should
 be limited by a FK (for the prefetched query).

 This hints at a flaw in your design: You can't memoize based only on the
 call from the manager. You need to take account of how the manager was
 constructed. Also, on first reading your code, I thought it odd that you'd
 choose to put memoization on the manager class rather than the queryset
 class.

--
Ticket URL: <https://code.djangoproject.com/ticket/24702#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.08de8341d8b87c2a9a8c7d48b5110347%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to