#24374: IncludeNode should use Template._render rather than Template.render
--------------------------------------+------------------------------------
Reporter: prestontimmons | Owner: adamzap
Type: Cleanup/optimization | Status: assigned
Component: Template system | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by prestontimmons):
Hi adamzap. I hope this isn't discouraging, but I'm going to close this
ticket as invalid. There are subtle differences between `context.push()`
and `context.render_context.push()` that I didn't understand when I opened
this ticket. The former happens in the `IncludeNode`, but the latter as
part of `Template.render()`. Although the tests don't catch it, changing
to `Template._render()` here would introduce a bug for `IncludeNode`
similar to #24555.
Anyhow, thanks for making a PR, but sorry I forgot to close this one
earlier.
--
Ticket URL: <https://code.djangoproject.com/ticket/24374#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/072.1615876a9f890ee374448934b1951296%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
