#24483: keepdb migrations break choices as generators
-------------------------------------+-------------------------------------
Reporter: davidszotten | Owner: Tim
| Graham <timograham@…>
Type: Bug | Status: closed
Component: Migrations | Version: 1.8beta2
Severity: Normal | Resolution: fixed
Keywords: migrations test | Triage Stage: Accepted
keepdb |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* owner: => Tim Graham <timograham@…>
* resolution: => fixed
Comment:
In [changeset:"80e3444eca045799cc40e50c92609e852a299d38" 80e3444]:
{{{
#!CommitTicketReference repository=""
revision="80e3444eca045799cc40e50c92609e852a299d38"
Fixed #24483 -- Prevented keepdb from breaking with generator choices.
If Field.choices is provided as an iterator, consume it in __init__
instead
of using itertools.tee (which ends up holding everything in memory
anyway). Fixes a bug where deconstruct() was consuming the iterator but
bypassing the call to `tee`.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24483#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/070.59aa7ee1886a19db15b68e9aba4ef5f7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
