#24441: core.files.images.get_image_dimensions broken on invalid images
-------------------------------------+-------------------------------------
Reporter: artscoop | Owner: nobody
Type: Bug | Status: new
Component: Core (Other) | Version: 1.7
Severity: Normal | Resolution:
Keywords: imagefield, | Triage Stage: Accepted
imagefilefield |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by artscoop):
Good catch. Then the most important thing would be to consider existing
databases with `ImageField`ed models.
Those existing projects have:
- no `width_field` or `height_field`, but cached attributes in the
`ImageField` (here, any value should be ok)
- `width_field` and `height_field` which are `NOT NULL` `IntegerField`s.
(these would only accept 0 or -1)
- `width_field` and `height_field` which are `NULL` `IntegerField`s.
(these would only accept None, 0 or -1)
- `width_field` and `height_field` which are `NOT NULL`
`PositiveIntegerField`s. (these would only accept 0)
- `width_field` and `height_field` which are `NULL`
`PositiveIntegerField`s. (these would only accept None or 0)
`0` is the only value that cannot break an existing database and would
thus not need a migration.
New projects could also use any type of `IntegerField` for their
dimensions.
Seems right, right ?
--
Ticket URL: <https://code.djangoproject.com/ticket/24441#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.68c1bd08e6a1ecc5eacbb113fc84ff80%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
