#24372: Remove django.template.base.TokenParser?
-------------------------------------+-------------------------------------
Reporter: prestontimmons | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Template system | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by prestontimmons):
Yes.
TokenParser was added as part of the original i18n branch:
https://github.com/django/django/commit/5cf8f684237ab5addaf3549b2347c3adf107c0a7
At that time, it was used by both the trans and blocktrans tags.
The blocktrans tag was changed to use traditional parsing when the with
syntax was updated:
https://github.com/django/django/commit/3ae9117c467f9fabed8736949dee209d40293b8d
This left the trans tag as the only one using TokenParser.
The unit tests for the trans tag in template_tests and i18n are fairly
comprehensive. I added additional tests in this patch for the syntax error
cases.
--
Ticket URL: <https://code.djangoproject.com/ticket/24372#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/072.6c56b8458fd04a580bb86c3462c3c855%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
