#24439: make_object_list attribute mis-used in GCBV Documentation
-------------------------------+---------------------------------------
Reporter: jambonrose | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: 1.7
Severity: Normal | Keywords: generic class-based-views
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+---------------------------------------
The attribute `make_object_list` is defined in `BaseYearArchiveView`,
[https://github.com/django/django/blob/fde4857fb83101d27ae4cb3552a6a6cf20d3d8ce/django/views/generic/dates.py#L445
on line 445 of `django/views/generic/dates.py`].
The only class to inherit from `BaseYearArchiveView` is `YearArchiveView`
([https://github.com/django/django/blob/fde4857fb83101d27ae4cb3552a6a6cf20d3d8ce/django/views/generic/dates.py#L485
on line 485 of the same file]). Therefore, the only two classes where the
`make_object_list` are `BaseYearArchiveView` and `YearArchiveView`.
However, in addition to the two classes above,
[https://docs.djangoproject.com/en/1.7/ref/class-based-views/generic-date-
based/ the reference documentation] uses the `make_object_list` attribute
on examples of:
* `MonthArchiveView`
* `WeekArchiveView`
* `DayArchiveView`
* `TodayArchiveView`
In these instances, the attribute will have no effect, but is misleading,
and should be removed.
--
Ticket URL: <https://code.djangoproject.com/ticket/24439>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/053.0fda5a4fb2207b9bf1d5db037574d3c1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
