#24423: Combine i18n template tag tests?
--------------------------------------+--------------------
Reporter: prestontimmons | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Internationalization | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
I was working on #25372 and noticed there isn't an obvious place to add
extra tests. This is because the `i18n` tag tests are currently split
among `i18n` and `template_tests.syntax_tests.test_i18n`. I think these
tests should be combined in one place or the other.
I propose the following:
1) Move the tag-related tests from `i18n` into `template_tests`
2) Split `template_tests.syntax_tests.test_i18n` into separate files for
each tag (test_trans.py, test_blocktrans.py, etc.)
I think change 1 makes sense because `template_tests` is also where we
have tests for things like staticfiles, cache, etc. The timezone tags are
the only outlier here.
Change 2 is a pattern we adopted when converting the filter tests to unit
tests. I think it would be good for template tag tests to follow the same
pattern.
Does this seem like the right grouping?
--
Ticket URL: <https://code.djangoproject.com/ticket/24423>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/057.31ff2483a69b53f92edb8a6180dbce20%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
