#24331: SuccessMessageMixinTests fail if MESSAGE_STORAGE is not CookieStorage
----------------------------------+--------------------------------------
     Reporter:  matt-leach        |                    Owner:  nobody
         Type:  Bug               |                   Status:  new
    Component:  contrib.messages  |                  Version:  master
     Severity:  Normal            |               Resolution:
     Keywords:                    |             Triage Stage:  Unreviewed
    Has patch:  0                 |      Needs documentation:  0
  Needs tests:  0                 |  Patch needs improvement:  0
Easy pickings:  0                 |                    UI/UX:  0
----------------------------------+--------------------------------------

Comment (by matt-leach):

 Have just noticed that in tests/messages_tests/urls.py
 `ContactFormViewWithMsg` should use reverse_lazy (as below) rather than
 passing in the view object to success url (`success_url = show`). Is that
 worth fixing?

 {{{
 class ContactFormViewWithMsg(SuccessMessageMixin, FormView):
     form_class = ContactForm
     success_url = reverse_lazy('show_message')
     success_message = "%(name)s was created successfully"
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24331#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.82f28f3afe54ce9ef46ccd116553aad6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to