#24281: auto_now & auto_now_add ignore TIME_ZONE / USE_TZ settings for DateField
-------------------------------------+-------------------------------------
Reporter: djbug | Owner: nobody
Type: Bug | Status: new
Component: | Version: 1.7
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by djbug):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Old description:
> `auto_now` & `auto_now_add` ignore TIME_ZONE / USE_TZ settings for
> `DateField`
>
> https://github.com/django/django/blob/1.7/django/db/models/fields/__init__.py#L1146
>
> def pre_save(self, model_instance, add):
> if self.auto_now or (self.auto_now_add and add):
> value = datetime.date.today()
> setattr(model_instance, self.attname, value)
> return value
> else:
> return super(DateField, self).pre_save(model_instance, add)
>
> Instead of `datetime.date.today()`, this should use
> `timezone.now().date()`.
New description:
`auto_now` & `auto_now_add` ignore TIME_ZONE / USE_TZ settings for
`DateField`
https://github.com/django/django/blob/1.7/django/db/models/fields/__init__.py#L1146
{{{
def pre_save(self, model_instance, add):
if self.auto_now or (self.auto_now_add and add):
value = datetime.date.today()
setattr(model_instance, self.attname, value)
return value
else:
return super(DateField, self).pre_save(model_instance, add)
}}}
Instead of `datetime.date.today()`, this should use
`timezone.now().date()`.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/24281#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/063.78f5729c29f0b25e5a1e203b9dee89be%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
