#24239: Possible problem in CVE-2015-0219 fix for 1.4.x
-------------------------------+------------------------------------
Reporter: rhertzog | Owner: nobody
Type: Bug | Status: new
Component: HTTP handling | Version: 1.4
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by carljm):
* component: Uncategorized => HTTP handling
* stage: Unreviewed => Accepted
Comment:
Hi - thanks for the report! This was a mistake in backporting that patch
to 1.4. However, I'm pretty sure in practice it's harmless - the custom
implementation of `get_environ()` there has been unnecessary for a long
time (in fact, I'm not sure why it was ever necessary at all). It was
simply removed (without requiring any compensating changes) in
https://github.com/django/django/commit/681550ca6d5ff3e591a769643e37fd0b50f29c91,
which is why it doesn't exist in more recent Django versions. Relying on
the standard-library `get_environ()` implementation is better.
If this issue had been caught before the release, I would say your fix is
the right one, for stability reasons. But now that we have a 1.4 release
in the wild which effectively is using the stdlib's `get_environ()` anyway
(and nobody has reported a practical problem with that, nor would I expect
any), I think we should just remove the custom `get_environ()` in the
1.4.x branch.
--
Ticket URL: <https://code.djangoproject.com/ticket/24239#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.a8fa6fe0a0b4d9660f1fc22f9ace2291%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
