#23765: Get rid of system check 1_6.W002
--------------------------------------+--------------------
Reporter: marfire | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (System checks) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
System check `1_6.W001` was recently removed (#23469); `1_6.W002` has the
same problems, and more, so I propose it be removed as well.
There is a serious false positive problem here (where I define a false
positive as something that makes you take time to think and care about
something you don't need to think or care about). For this warning to
actually help you, you must meet the following conditions: you haven't
read the release notes; you're upgrading from a pre-1.6 version; you're
using `BooleanFields` without a default; and you're nevertheless relying
on the default value to be `False`. I don't have any hard numbers, of
course, but I suspect this represents a small and dwindling proportion of
users.
Another problem with this is that the most straightforward solution (and
the one hinted at by the warning message) is to go around and add defaults
to all your `BooleanFields`. That is, in general, a mistake. Unless you
actually want there to be a default, adding one harms your ability to
detect bugs through model and form validation.
Since `1_6.W001` is being removed in 1.8, that seems reasonable here as
well. In both cases, though, it seems like these warnings should have been
added to the `SILENCED_SYSTEM_CHECKS` setting in the default project
template for new projects. That could certainly be done in the next 1.7
release.
--
Ticket URL: <https://code.djangoproject.com/ticket/23765>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/050.8034ec6eb8bfecbd67650bdaa16e67e9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.