#23703: django.db.models.field.subclassing overwrites my subclass
-------------------------------+--------------------
Reporter: mozumder | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: 1.7
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
In the file subclassing.py, should the following:
-------
def make_contrib(superclass, func=None):
"""
Returns a suitable contribute_to_class() method for the Field
subclass.
If 'func' is passed in, it is the existing contribute_to_class()
method on
the subclass and it is called before anything else. It is assumed in
this
case that the existing contribute_to_class() calls all the necessary
superclass methods.
"""
def contribute_to_class(self, cls, name):
if func:
func(self, cls, name)
else:
super(superclass, self).contribute_to_class(cls, name)
setattr(cls, self.name, Creator(self))
return contribute_to_class
-------
(note the setattr() is outside of the if func.)
instead be:
-------
def make_contrib(superclass, func=None):
"""
Returns a suitable contribute_to_class() method for the Field
subclass.
If 'func' is passed in, it is the existing contribute_to_class()
method on
the subclass and it is called before anything else. It is assumed in
this
case that the existing contribute_to_class() calls all the necessary
superclass methods.
"""
def contribute_to_class(self, cls, name):
if func:
func(self, cls, name)
else:
super(superclass, self).contribute_to_class(cls, name)
setattr(cls, self.name, Creator(self))
return contribute_to_class
-------
(note the setattr() is inside of the if func.)
Should the setattr() should be called only when there isn’t a
contribute_to_class() method.
I ask because in my own custom field, I have a contribute_to_class()
function as well:
-------
def contribute_to_class(self, cls, name):
super(myCustomField, self).contribute_to_class(cls, name)
setattr(cls, self.name, myCustomCreator(self))
-------
But, because of the setattr() in the SubfieldBase metaclass, my own
setattr() gets overwritten by the default set_attr().. I therefore can’t
have my own field of the same name with my own custom Creator().
Is this expected behavior? I would like to be able to produce my own
Creator() function.
-bobby
--
Ticket URL: <https://code.djangoproject.com/ticket/23703>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/051.3e67eabf9c702ebd5bf28c9fd87c35a2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
