#23546: callproc **kwargs or *args parameter
-------------------------------------+-------------------------------------
     Reporter:  fatal10110           |                    Owner:
         Type:  New feature          |  averybigant
    Component:  Database layer       |                   Status:  assigned
  (models, ORM)                      |                  Version:  1.7
     Severity:  Normal               |               Resolution:
     Keywords:  oracle               |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by averybigant):

 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0


Comment:

 Replying to [comment:7 shaib]:
 > Hi,
 >
 > I made some notes on the PR. Additionally, documentation needed. I
 suggested making the feature more general, less Oracle-specific, but even
 if this path is not taken, the new behavior needs to be documented.
 Currently, callproc is not documented at all, which is a shame, but
 forgivable considering that the function is as defined in PEP 249;
 deviating from the PEP justifies adding explicit documentation, probably
 in `docs/topics/db/sql.txt`; whether or not that is done, the addition
 should be mentioned in the release notes (`docs/releases/1.8.txt`).

 Thanks for your detailed comments. New commit pushed. I also replied your
 comments on github.

--
Ticket URL: <https://code.djangoproject.com/ticket/23546#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e1c4fe19a5511926876d2ea36ad83831%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to