#23587: Paragraph on over-riding base_html can be misread as to WHAT needs to be
changed...
-------------------------------------+-------------------------------------
Reporter: Pyrrhicv | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: 1.7
Component: Documentation | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: base_site.html | Needs documentation: 0
tutorial 2 | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timgraham):
* has_patch: 0 => 1
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
What error did you get using `{{ _('Polls administration') }}`? I think
it's probably not important to make this text translatable which is the
purpose of the curly braces and underscore and if it adds confusion it
seems fine to remove to me.
I didn't include a description of why just replacing the text in
`'site_title|default:_('Django admin')'` does not work as I thought it
could be even more confusing (the default is needed in some edge cases
where the `site_title` variable doesn't exist in the template context). Do
you think that explanation would help?
Please take a look at the attached patch and let me know if it looks okay.
--
Ticket URL: <https://code.djangoproject.com/ticket/23587#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.e27b46e252a9e364a7392a7da6cbae3f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
