#23426: migrations.RunSQL's function signature implies it won't do any parameter
substitution
-------------------------------------+-------------------------------------
     Reporter:  ris                  |                    Owner:
         Type:                       |  Markush2010
  Cleanup/optimization               |                   Status:  closed
    Component:  Migrations           |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:  migrations sql       |             Triage Stage:  Accepted
  runsql params escape               |      Needs documentation:  0
    Has patch:  1                    |  Patch needs improvement:  1
  Needs tests:  0                    |                    UI/UX:  0
Easy pickings:  0                    |
-------------------------------------+-------------------------------------
Changes (by loic):

 * needs_better_patch:  0 => 1
 * version:  1.7 => master
 * easy:  1 => 0


Comment:

 Reopening for the 1.8 branch.

 The implementation proposed in PR3267 won't play well with multiple
 statements (e.g. two INSERT statements separated by a semicolon).

 Possible fix, make `params` and `reverse_params` a list whose length must
 match the number of SQL statements.

--
Ticket URL: <https://code.djangoproject.com/ticket/23426#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.7e58120a56503a363e428b239363d462%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to