#23481: Cannot view Trac tickets when logged in through GitHub
-------------------------------------+-------------------------------------
Reporter: kevin-brown | Owner: nobody
Type: Bug | Status: new
Component: *.djangoproject.com | Version:
Severity: Normal | Resolution:
Keywords: | Triage Stage:
Has patch: 0 | Unreviewed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by aaugustin):
Ah, OK, it return the empty string in my testing.
This patch in trac-github should fix it:
{{{
diff --git a/tracext/github.py b/tracext/github.py
index 2033e48..d437ce0 100644
--- a/tracext/github.py
+++ b/tracext/github.py
@@ -69,8 +69,8 @@ class GitHubLoginModule(LoginModule):
# Small hack to pass the username to _do_login.
req.environ['REMOTE_USER'] = user['login']
# Save other available values in the session.
- req.session.setdefault('name', user.get('name', ''))
- req.session.setdefault('email', user.get('email', ''))
+ req.session.setdefault('name', user.get('name') or '')
+ req.session.setdefault('email', user.get('email') or '')
return super(GitHubLoginModule, self)._do_login(req)
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23481#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/069.5622decec46c3dcfaead151d6e150b7d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
