#23436: Should use abspath for default settings.BASE_DIR
-------------------------------------+-------------------------------------
Reporter: hjwp | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: 1.6
Component: Uncategorized | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by hjwp):
* status: closed => new
* resolution: duplicate =>
Comment:
with due respect, I'm going to tentatively re-open this ticket. #21409
seems to be about changing BASE_DIR to being a different directory,
whereas this ticket asks for BASE_DIR to be an absolute path.
#21409 was closed by @aaugustin, appropriately I think, because BASE_DIR
is exactly where it should be.
But after that, actually, the discussion in #21409 looks like it started
to be about whether the path should be absolute or relative. I couldn't
see any arguments for keeping it relative, and there's definitely an
argument against it (ie, it can cause confusion as per my initial
submission above, and also, it's the default in Python3.4 anyway, so if we
don't do it then that introduces different behaviours for django under
python2 vs 3)
One person did make a case for using joins of `os.pardir` instead of
double path.dirname, which I guess would be fine (although it feels like
the "more semantic" benefit is outweighed by the "harder to read" price).
But in the meantime, I feel like BASE_DIR should definitely be an absolute
path...
--
Ticket URL: <https://code.djangoproject.com/ticket/23436#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/062.b455a6bc3641fd109ccd13fe8bfbb6cf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
