#23403: sitemap crashes if lastmod returns a date (instead of datetime)
-----------------------------------+------------------------------------
Reporter: igorcc | Owner: igorcc
Type: Bug | Status: assigned
Component: contrib.sitemaps | Version: 1.7
Severity: Release blocker | Resolution:
Keywords: date utctimetuple | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Comment (by igorcc):
OK, in this case there could be more clear solution, working for both date
and datetime:
@@ -75,5 +75,5 @@
# if latest_lastmod is defined for site, set header so as
# ConditionalGetMiddleware is able to send 304 NOT MODIFIED
response['Last-Modified'] = http_date(
- timegm(site.latest_lastmod.utctimetuple()))
+ timegm(site.latest_lastmod.timetuple()))
return response
Thank you!
--
Ticket URL: <https://code.djangoproject.com/ticket/23403#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.9f9d065151a333a8f5c7b22eee510e51%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
