#22918: migrations.operations.SeparateDatabaseAndState crashes (and has no
tests)
----------------------------+------------------------------------
Reporter: timo | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 1.7-rc-3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------+------------------------------------
Comment (by etianen):
I think this should really count as a release blocker. The code is
trivially broken, and trivially fixable. Removing it from the docs just
sidesteps the issue, and there are some migration operations that can only
be done using this class. (So far as I can tell, this is the only way to
move models from one app to another. Maybe there is another, simpler way?
If so, I'm all ears!)
I'll spend a couple of hours today writing the tests. Really, though, if
the patch can't be pulled because of lack of tests, how did the original
feature get in with no tests? I'm 100% for maintaining code quality, but
if the core developers are not subject to the same code quality
guidelines, an insistence on tests just makes it harder for non-core
developers to contribute.
--
Ticket URL: <https://code.djangoproject.com/ticket/22918#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/062.b27b1dbc19e0233d14d26e66f40a7226%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
