On Aug 29, 6:58 pm, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > On Fri, 2008-08-29 at 10:23 -0700, Nuno Mariz wrote: > > Just submitted a patch for the Portuguese translation: > >http://code.djangoproject.com/ticket/8685 > > I think was not updated since 0.96 version > > So, a couple of things for the future (and this applies to everybody, > not just you, but it was your patches I was just committing)... > > Don't take what follows the wrong way. You did a full translation. It > applied without problems and is now in 1.0. I am very appreciative of > the hard work you've done and you have my thanks (and those of people > using Django in Portugese). I am writing here for the general audience, > not just you, Nuno: > > The preferred format, even for translations, is a diff against the > current SVN. That makes it a lot easier to check that you are indeed > patching the correct files against a recent version. People who attach > the whole file make that harder to sanity check (and, yes, mistakes > happen, so the sanity check is useful). Don't worry when Trac doesn't > display your patch correctly. That's a bug in Trac. It's still attached > and I can still download the original format and apply it. That's a > horrible user interface problem in Trac, I agree, but once you just > trust that your patch is attached properly, it becomes easier. If > there's a problem, we'll let you know. > > I know you attached two patches, but this is the second point. Patch > files are awesome. A single file can patch multiple source files at > once. So *one* patch file is the recommended maximum. :-) > > Start at the top of the source tree (the directory you checked out of > subversion) and run "svn diff > translation-update.diff". > > The advantage of this is that then the patch file contains the full path > to the files being patched. If you create the diff inside the locale > directory (e.g. inside pt/LC_MESSAGES/), I -- or whoever does the > commits -- has to work out which locale is being patched and move to the > right directory. This isn't as easy as you might expect. Okay, Portugese > is "pt", that's not too hard to remember. But Georgian is "ka", Irish is > "ga" and there's a very subtle difference between "zh_CN" and "zh_TW". > Remember that we don't all speak your language. > > So, for everybody: don't make the committers have to guess. We're not > very smart. We make mistakes. A lot. Please help us! :-) > > Despite all this, I realise it's a bit of a tedious process sometimes. > We're not going to reject translations just because people make a few > process mistakes. Sometimes we might ask for another submission, but we > always want translations. So thankyou to everybody who is doing the hard > work to get these things up to date. > > Interesting fact: Over half of the visitors to djangoproject.com have a > language other than English set as the preference in their browser. So > we already reach a wide international audience. You guys can take a lot > of the credit for that. > > Best wishes, > Malcolm
Ok Malcolm, Sorry about the messy patching, note taken. Should I submit another ticket with this process? Thanks, Nuno --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django I18N" group. To post to this group, send email to Django-I18N@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/Django-I18N?hl=en -~----------~----~----~----~------~----~------~--~---
