I’m on the other side of the fence – I don’t think this is a necessary change.

The examples given in historic tickets are not worthy of a change like this in 
my opinion. For example, take the example regarding a bot crawling a website, 
and losing its session by crawling the logout link – if you were crawling any 
website using a bot with an authenticated session, you would instruct the bot 
to not crawl the logout links. In 15 years of web development, I’ve yet to ever 
find a bot using an authenticated session.

Are any current browsers dumb enough to prefetch logout links these days? I 
would assume that most prefetch algorithms are smart enough to not pre-fetch 
these.

I have also seen the argument floated around that it’s not “correctly restful” 
to modify the state (session data) via a GET request. I’d say that sessions 
themselves are not restful by nature.

I just don’t see the benefit, in return for breaking practically every logout 
button on every installation of Django around.

B

From: <[email protected]> on behalf of Adam Johnson 
<[email protected]>
Reply to: "[email protected]" 
<[email protected]>
Date: Friday, 28 February 2020 at 15:47
To: "[email protected]" <[email protected]>
Subject: Re: Deprecating logout via GET

Wow and first ticket referenced in one of those conversations was 12 years ago: 
https://code.djangoproject.com/ticket/7989<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcode.djangoproject.com%2Fticket%2F7989&data=01%7C01%7Cbrian.maher%40kcl.ac.uk%7Ca77c6bd038644dfe2dd308d7bc6581cf%7C8370cf1416f34c16b83c724071654356%7C0&sdata=ml9pq6XmLak1ie7crz9lpnHgVcJDgYdKiGCf1CNpHTw%3D&reserved=0>

Seems like a of a no-brainer at this point with general support from other core 
devs in the past :)

On Fri, 28 Feb 2020 at 00:10, René Fleschenberg 
<[email protected]<mailto:[email protected]>> wrote:
Hi,

On 2/28/20 12:12 AM, Adam Johnson wrote:
>  > The reason this was not changed yet is backwards compatibility.
>
> Do you have any mailing list / ticket links as reference?

Sorry, I forgot to link them here. The main ticket seems to be
https://code.djangoproject.com/ticket/15619<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcode.djangoproject.com%2Fticket%2F15619&data=01%7C01%7Cbrian.maher%40kcl.ac.uk%7Ca77c6bd038644dfe2dd308d7bc6581cf%7C8370cf1416f34c16b83c724071654356%7C0&sdata=Iu5On9p2H%2BibRa%2BHVwDlFPjI0x3TEni3Du%2BJINbpjtk%3D&reserved=0>.

Mailing list dicussions are at
https://groups.google.com/forum/#!topic/django-developers/MmFzCq8oB5I/discussion<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fforum%2F%23!topic%2Fdjango-developers%2FMmFzCq8oB5I%2Fdiscussion&data=01%7C01%7Cbrian.maher%40kcl.ac.uk%7Ca77c6bd038644dfe2dd308d7bc6581cf%7C8370cf1416f34c16b83c724071654356%7C0&sdata=nGlfTICqIGAZYNuHXuD%2Fc6%2B7U4oPLSC1MMvKZxJiFJg%3D&reserved=0>
and
https://groups.google.com/forum/#!topic/django-developers/ax95u_f82D4/discussion<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fforum%2F%23!topic%2Fdjango-developers%2Fax95u_f82D4%2Fdiscussion&data=01%7C01%7Cbrian.maher%40kcl.ac.uk%7Ca77c6bd038644dfe2dd308d7bc6581cf%7C8370cf1416f34c16b83c724071654356%7C0&sdata=3QNN56EfELEEKt3U1b%2B0fib6xCJSMzarzc8k09qrs7w%3D&reserved=0>.

--
René Fleschenberg

--
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to 
[email protected]<mailto:django-developers%[email protected]>.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/f6c73570-5276-d789-db00-c162457ac5bb%40fleschenberg.net<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fd%2Fmsgid%2Fdjango-developers%2Ff6c73570-5276-d789-db00-c162457ac5bb%2540fleschenberg.net&data=01%7C01%7Cbrian.maher%40kcl.ac.uk%7Ca77c6bd038644dfe2dd308d7bc6581cf%7C8370cf1416f34c16b83c724071654356%7C0&sdata=kVaydulTOIWsVMJhH74hOGMBdVCENNsrUQS%2BInd3Ll4%3D&reserved=0>.


--
Adam
--
You received this message because you are subscribed to the Google Groups 
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to 
[email protected]<mailto:[email protected]>.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM3r_68yowcjGnr9kBPSFwcfHnP6VKgsmuBsBfk3c7rJ%3Dg%40mail.gmail.com<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fd%2Fmsgid%2Fdjango-developers%2FCAMyDDM3r_68yowcjGnr9kBPSFwcfHnP6VKgsmuBsBfk3c7rJ%253Dg%2540mail.gmail.com%3Futm_medium%3Demail%26utm_source%3Dfooter&data=01%7C01%7Cbrian.maher%40kcl.ac.uk%7Ca77c6bd038644dfe2dd308d7bc6581cf%7C8370cf1416f34c16b83c724071654356%7C0&sdata=qoJ5LGSRTTqL31n5EN0bxcNokgWQVac3HdSThY1DB2M%3D&reserved=0>.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/726EBC60-9116-453C-9DA9-2FCD675D8301%40kcl.ac.uk.
  • Dep... René Fleschenberg
    • ... Adam Johnson
      • ... René Fleschenberg
        • ... Adam Johnson
          • ... 'Maher, Brian' via Django developers (Contributions to Django itself)
            • ... Florian Apolloner
            • ... René Fleschenberg
    • ... אורי
      • ... Adam Johnson
        • ... Florian Apolloner
          • ... René Fleschenberg
          • ... אורי
            • ... Adam Johnson
              • ... Aymeric Augustin
                • ... Anna Sidwell

Reply via email to