The page you referred to says: >First request the feature on the django-developers <https://docs.djangoproject.com/en/dev/internals/mailing-lists/#django-developers-mailing-list> list, not in the ticket tracker.
That's why I'm here ¯\_(ツ)_/¯ About my case — in general, I want to make a websocket server. Django Channels is too complicated and I don't want to use it for my case; instead, I want to make a very stupid and primitive server (without consumers, routers, channel layers and other scary words; less than 0.5k lines of code). But I still need to authenticate the user, and I want to do exactly what Channels does — get the user model instance for current websocket scope. Now, to prevent code duplication, I have to do something like this: def get_session(self): SessionStore = importlib.import_module(settings.SESSION_ENGINE).SessionStore # self.session_key is loaded from websocket cookies return SessionStore(self.session_key) def get_user_model(self): from django.contrib.auth import get_user from django.http.request import HttpRequest request = HttpRequest() request.session = self.get_session() return get_user(request) But this is obviously ugly. But creating a copy of the "get_user" function and modifying it to fit my needs is even worse. The "get_user_by_session_key" functionI propose can dramatically simplify this code and increase reliability. The same applies to Channels that can get rid of its own copy of the "get_user" function. I expect you'll say "just use Channels and don't be an idiot", but I think this small refactoring will be good anyway, even for Channels. I don't quite understand what you mean by saying "isn't the only thing that would need changing"; as of today, I have not noticed any problems when working with the session without a real request. (I know that it’s not very safe to work with the ORM in async code, but don't worry, I took care of this.) 26.07.2019 19:39, Adam Johnson пишет: > Hey, > > Welcome to the mailing list. This is probably a little low-level as a > feature request here. I think it is better submitted as a ticket as > per > https://docs.djangoproject.com/en/dev/internals/contributing/bugs-and-features/ > :) > Where on the docs did you read about django-developers? > > As for your suggested feature - could you talk about your use case a > little more? If Django is going to support sessions not attached to > requests, it's likely this isn't the only thing that would need > changing. And as you've seen in the source, the function you want > right now is only one line (get_user_session_key). > > Thanks, > > Adam > > On Thu, 25 Jul 2019 at 14:09, 'andreymal' via Django developers > (Contributions to Django itself) <[email protected] > <mailto:[email protected]>> wrote: > > (Hello, the Django documentation says that I should send feature > requests to the django-developers mailing list, so I send it here.) > > I have a need to get a user object using a known session key > without an > HTTP request. After reading the Django code, I did not find a > clean way > to do this. > > Django has the "get_user" function that requires a request object. But > it actually uses only "request.session" and nothing else. So I suggest > refactoring it something like this: > > # > > https://github.com/django/django/blob/master/django/contrib/auth/__init__.py > def _get_user_session_key(session): > return get_user_model()._meta.pk.to_python(session[SESSION_KEY]) > > def get_user(request): > return get_user_by_session(request.session) > > def get_user_by_session_key(session_key): > SessionStore = import_module(settings.SESSION_ENGINE).SessionStore > return get_user_by_session(SessionStore(session_key)) > > def get_user_by_session(session): > from .models import AnonymousUser > user = None > try: > user_id = _get_user_session_key(session) > backend_path = session[BACKEND_SESSION_KEY] > except KeyError: > pass > else: > ... # the rest of the code > return user or AnonymousUser() > > Note that Django Channels has similar code so the > "get_user_by_session" > function can help to deduplicate it: > https://github.com/django/channels/tree/master/channels/auth.py#L23 > > -- > You received this message because you are subscribed to the Google > Groups "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, > send an email to [email protected] > <mailto:django-developers%[email protected]>. > To view this discussion on the web visit > > https://groups.google.com/d/msgid/django-developers/858abfe1-42b9-185b-e69c-c23d6058e762%40andreymal.org. > > > > -- > Adam > -- > You received this message because you are subscribed to the Google > Groups "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected] > <mailto:[email protected]>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/CAMyDDM3vn6SP2q951_1keJnaQhAbTEY3rfK_X-FvSSLOtQoTCw%40mail.gmail.com > <https://groups.google.com/d/msgid/django-developers/CAMyDDM3vn6SP2q951_1keJnaQhAbTEY3rfK_X-FvSSLOtQoTCw%40mail.gmail.com?utm_medium=email&utm_source=footer>. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/d72e1e22-4e65-2c25-391e-a942b73cb498%40andreymal.org.
