Hi, On Saturday, April 13, 2019 at 9:41:38 PM UTC+2, Berker Peksağ wrote: > > I came here to say exactly this. Django's codebase is already pretty > consistent with its own style and I think having a usable "git blame" > is much more important than starting to use a new code formatter.
I am not sure I agree with this argument. We already have had big code changes which make git blame useless (if you are looking for a commit from like 8 years ago or so). All we are doing to do is adding one commit more to that list (and the tooling to work around one such a commit is good, ie git-hyper-blame, git gui blame etc etc). > with a codebase as big as Django, trying to adapt a different style > guide would only cause unnecessary code churn. > Maybe, but I think the benefits outweigh the costs -- and I also do not think that it is unnecessary. Our goal has always been to make contributing easier, well nowadays black is in the position to do just that. The following style is much more readable (and it also makes future > diffs less noisy since we can add new formats without having reformat > code and comments) than black-formatted code: > Yes, the formats (same for settings files) are imo certainly files we could exclude from black. That said those files are highly specific and hardly representative for python code. Cheers, Florian -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/7eb37396-04a0-41a7-960f-cbcbd4ac0001%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
