I can be a quite useful option when mergers have to perform small typos and code style tweaks before a merge.
I'm not sure it's worth documenting given it's the default value though. Simon Le dimanche 17 mars 2019 15:17:32 UTC-4, Adam Johnson a écrit : > > 3. I believe I’ve seen Tim use the maintainers’ edits feature. Perhaps we > should guide towards its usage? > > On Sun, 17 Mar 2019 at 17:21, Aymeric Augustin < > [email protected] <javascript:>> wrote: > >> Hello Alexey, >> >> Thanks for contributing! >> >> 1. You should make a PR against master and, if you're fixing a Trac >> ticket, start the commit message with "Fixed #xxxxx -- bla bla bla". >> >> Version indicators such as [2.0.x] are added when patches are backported >> to stable branches. You don't need to care about this now. If your issue is >> eligible >> for backporting >> <https://docs.djangoproject.com/en/dev/internals/release-process/#supported-versions-policy>, >> >> then the person who merges the patch will likely do the backport as well. >> >> 2. Yes, your fork should be up to date with Django's master branch to >> ensure that the PR is clean. >> >> See Working with git / After upstream has changed >> <https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/working-with-git/#after-upstream-has-changed> >> for >> details (read the whole page, commands listed in that paragraph depend on >> other commands listed earlier). >> >> 3. As you wish :-) >> >> I'm not aware of any guidelines about this relatively new GitHub feature >> when contributing to Django. >> >> Best regards, >> >> -- >> Aymeric. >> >> >> >> On 17 Mar 2019, at 10:34, Alexey Tsivunin <[email protected] >> <javascript:>> wrote: >> >> I worked on issue and fixed a bug. So a have three commits (in the >> sequence they were commited): >> - Added regression tests >> - Added bugfix >> - Added name to AUTHORS >> >> This is my first PR and I have several questions: >> >> 1. I don't quite understand about "headers" in commit messages. Which >> commit should have header like "[2.0.x] Fixed #29471 -- "? Or each of them >> should have it? >> >> 2. Does my fork have to be up-to-date with original django repo before I >> make the PR? If so, is there any guides how I can do this? >> >> 3. Should I select *"Allow edits from maintainers"* when creating PR? >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers (Contributions to Django itself)" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To post to this group, send email to [email protected] >> <javascript:>. >> Visit this group at https://groups.google.com/group/django-developers. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-developers/e550ba3f-c6d4-49f5-94e2-29cfd0ee6798%40googlegroups.com >> >> <https://groups.google.com/d/msgid/django-developers/e550ba3f-c6d4-49f5-94e2-29cfd0ee6798%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers (Contributions to Django itself)" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To post to this group, send email to [email protected] >> <javascript:>. >> Visit this group at https://groups.google.com/group/django-developers. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-developers/87832FCE-FA46-4717-BB1C-E6F0F8795694%40polytechnique.org >> >> <https://groups.google.com/d/msgid/django-developers/87832FCE-FA46-4717-BB1C-E6F0F8795694%40polytechnique.org?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- > Adam > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/d346a7fb-1fe0-45ec-ba6d-caa0882b50be%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
