I hit somewhat of a wall, and would like some input/help.

* Import of window functions from `django.db.model.functions` seems to be 
the
  convention - `DEFAULT_INDEX_TABLESPACE` causes some headaches, because of
  XField being explicitly set in _output_field variable. Probably the 
functions need some extra fine-tuning in some way. So
  far, most of the functions don't have explicit arguments in the 
constructor,
  because they either have a varying number of arguments (Lead and Lag, for
  instance) or don't take any (rank and row_number; however, those can take 
an
  argument in case somebody wants to add support for WITHIN 
GROUP-expression). I
  deleted the "_output_field = Field" from the functions that do take an
  argument, such as Lead and Lag, would it be required to explicit about the
  output_field, such as overriding the resolve_output_field-field? In those
  cases, it's always the type of the first argument or the default-argument 
in
  case it's provided/available. Tests are running locally without the 
explicit
  _output_field. And just to avoid shuffling around things later, any 
arguments
  against django.db.models.functions.window being the right place for this?

* `__repr__` and `__str__` methods and testing. What's a good general 
convention
  for something like this? I don't have access to the connection in 
__repr__,
  and __str__-methods, and thus just imported from `django.db` in the tests,
  which I suppose is not the ideal solution for this. At least, it doesn't
  really feel that way.

* Are there more cases which should fail apart from filtering (supported by
  filterable) and use in UPDATE (can_be_reffed_in_update)?

Thank you.

Kind regards,
Mads

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/d81ddfe0-f8f2-4ec0-99c9-96cd4b619246%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to