Hi everybody,

we've run into an interesting situation: we implemented a custom 
SimpleListFilter for the admin which presents the choices as a list of 
checkboxes. Pressing "submit" sends the list to the backend for filtering.

Unfortunately, this doesn't really work well and it took us a while to find 
out why: the ChangeList view request.GET (a QueryDict) into a dict 
<https://github.com/django/django/blob/master/django/contrib/admin/views/main.py#L67>
.

This means, a query string in the form of ?q=123&state=1&state=2 simply 
loses all state values except the last one. It still works in principle but 
as soon as you e.g. click on a column heading to re-sort, the link breaks.

I checked the git log and traced this re-casting back to the "NEW ADMIN 
MERGE 
<https://github.com/django/django/commit/9dda4abee1225db7a7b195b84c915fdd141a7260#diff-ea7d8c684e252f3dad6aa458df7d3070R109>"
 
in 2005. Does anyone know why this was done? Shouldn't we rather keep 
self.params as a QueryDict?

Thanks!

   Jonas

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/7c68a323-cd72-4e1f-a817-0c521d4b991e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to