> > It sounds like you are maybe proposing to decide whether to pre-initialize > logging with the built-in default config or not based on whether the user's > LOGGING setting has disable_existing_loggers set to True or False? >
Yes, I was thinking on my feet and this was one idea I came up with that would allow a sane migration story. But I don't like it either on the same grounds as you, it complicates things just a tad too much. > I think the best end result would be one where LOGGING simply defines the > full config and it is always applied (by Django) exactly once, and the > defaults we want are set as the global default for LOGGING, and just > documented so that people who want to set LOGGING themselves can easily > copy them as a starting point. > I'm actually for that, too. And the defaults should live in global_settings.py, not hard-coded in utils/log.py Funny, it was exactly like that before it's been changed to the current way in 1.5 :-) > But we'll need some kind of deprecation path to get there, at least for > people who currently have disable_existing_loggers=False, in order to > prevent them from suddenly losing the default config. > I'm not familiar with the current deprecation policy in Django. If you can point me to it, I could probably carve some time in the nearby future and prepare a pull request. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/e75d64a4-5205-4ff7-8d2e-c53e9c7ba117%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
