Some of the pools might have some high load (such as the one that handles
logging to the database and other sources) so opening and closing a
connection for each call might end up bad.
Now that you mention django code, does
connection.close_if_unusable_or_obsolete() always close the connection, or
does it also handle the case where persistent connections are used (and so
the connection is not closed if it is alive and in good state) ? If so,
would it possible to simply replicate what django does on every request
start and end as a wrapper of every function that's sent to the pool? That
way connections are re used if possible and recycled/closed if they go bad.
Looking at the code this seems to be called on every request start and end.
def close_old_connections(**kwargs):
for conn in connections.all():
conn.close_if_unusable_or_obsolete()
signals.request_started.connect(close_old_connections)
signals.request_finished.connect(close_old_connections)
I guess something could be done but just with that thread's connection,
then all functions sent to the pool will need to be sent through a wrapper
that does this before and after every call.
El jueves, 2 de junio de 2016, 20:50:13 (UTC-3), Stephen Butler escribió:
>
> Do you expect your background threads to be equivalent to or greater than
> the number of requests you're normally servicing? Usually background tasks
> are much less frequent than the web requests, so a little overhead w/r/t
> database connections isn't even going to be noticed.
>
> Looking at what Django does, at the start and end of each request it calls
> connection.close_if_unusable_or_obsolete(). That function does careful
> checks to see if the connection is even worth using. Unless you do
> something similar in your thread_start (adding more complication than I've
> suggested), having a TLS connection will cause more problems than it saves
> you. To make this work in general you'd at least need a hook at the point
> the thread is removed from and added back to the pool, not when the thread
> exits.
>
> Also, the connection won't be opened unless you actually do something that
> needs it.
>
> Personally, I think this sounds like something you're trying to optimize
> before you've profiled that the benefit it worth it.
>
>
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/3d668979-fae3-4a77-b9b4-fe9e09f763fa%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
