Hello Thomas, > On 5 déc. 2015, at 23:23, Thomas Grainger <[email protected]> wrote: > > I think merging django-csp into contrib would be a good fix for > https://code.djangoproject.com/ticket/15727 > <https://code.djangoproject.com/ticket/15727>
I took a look at the pull request. I understand that the “just merge django-csp” approach minimizes effort. However the result doesn’t feel well integrated with Django. I left a few comments that all boil down to “this isn’t how we would have done if we’d started from a clean slate” and quickly gave up when I noticed that trend. Thinking in terms of “we have Django, how do we best implement CSP?” — and liberally looking for API ideas or code in django-csp, since its license allows that — will yield better results than merely transplanting django-csp in django.contrib. That’s usually how Django integrates third-party code. Best regards, -- Aymeric. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/016D8E7F-129C-4DB7-9205-16C3E93C0537%40polytechnique.org. For more options, visit https://groups.google.com/d/optout.
