Hi all,

I have recently stumbled upon a very useful feature missing from 
`django.db.models.expressions`.

I came up with a patch and followed the guidelines to create my ticket: 
https://code.djangoproject.com/ticket/25556
and pull request: https://github.com/django/django/pull/5431

One thing I'm confused about is the fact that I would be adding new 
classes/functionality to the system (so I would really want to write tests 
for it), however similar classes in the same module seem not to be covered 
by tests at all. For instance, the only test for 
`django.db.models.expressions.Date` I could find was the one testing its 
`__repr__` method, which doesn't seem all that useful. 

One thing that's noticeable is that a lot of the more complex query 
expressions present there (like Date and DateTime) are not really covered 
by the documentation either (even though Date is used in `QuerySet.dates()` 
which is well documented). Are these features considered undocumented, and 
is there a plan to make them officially supported (because they're really 
useful)?


One other thing I wanted to inquire about is what is the best naming 
practice for django when adding new classes/methods/functions? I couldn't 
find anything on this.

Thank you so much. I hope I can contribute and help make django better!

Best regards,
     David Filipovic

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/b3efc237-d1a4-4954-8498-57633ff0dd51%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to