It's quite possible this is an area which is untested - partly because when it was originally written we didn't have the mock library to prevent the external url call. Adding tests would be wonderful.
Marc On 22 April 2015 at 17:29, ST LEON <[email protected]> wrote: > I want to contribute one new feature to Django (doing this first time). > > I reading this <https://docs.djangoproject.com/en/dev/intro/contributing/> and > have one question. > > First, write tests. I want to improve work of ping_google() > <https://github.com/django/django/blob/master/django/contrib/sitemaps/__init__.py#L17> > and > add some new behavior. > > But I can't find any tests that cover this function. > > I think, that it might be here > <https://github.com/django/django/tree/master/tests/sitemaps_tests>, but > I can't find tests for *ping_google()*. > > So, what should I do? That test needs me to see, how they works, change > some of them and write new ones. > > My changes aren't be so serious: just a very simple 2-3 new lines. > > Please, help. > > Thanks! > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/474b740a-adb2-4c72-b297-e91941bc3e63%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/474b740a-adb2-4c72-b297-e91941bc3e63%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMwjO1FHEp5s82afzhNRqxtnJJJfidTutxHM9TOWTgQLeaQ6Ag%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
