> On 07 Apr 2015, at 18:15, Aymeric Augustin > <[email protected]> wrote: > > 2015-04-07 17:25 GMT+02:00 Marc Tamlyn <[email protected]>: > The primary questions to establish answers to before a possible merge in my > opinion are: > - Do we ship both, or just the new one and release the old one as a third > party package? > > I'd like to make the new theme the default unless the developer opts out. > > Since the admin CSS and JS receives very little maintenance, keeping the > current theme under django/contrib/admin/classic_theme/static or in a > third-party package doesn't make a significant difference for us. > > The former is more convenient for users who choose to opt-out: all they need > is to add 'django.contrib.admin.classic_theme' before 'django.contrib.admin' > in INSTALLED_APPS. That will save us some angry emails ;-)
I don’t think we should keep it in django.contrib.admin.class_theme and just make a hard break (we don’t guarantee backward compatibility for styles or frontend API IIRC), but also offer a separate Python package at the time of the Django release with the new skin. > This leaves the question of how long we keep supporting the classic theme. I > suggest to go for the usual two-releases deprecation cycle and leave it up to > the community to maintain it separately from Django 2.1 on. When you say community, who are you referring to? I’d rather see the original skin moved into a repo under the django namespace on GitHub. Moving it into an own app inside of django.contrib.admin and then remove it just two releases (~1 year) later is a pretty good way to receive angry mails. > My suggestion would be that we should publicise via this mailing list (and > django-users etc) that we are planning to integrate this, and you can use it > now via your app. This should hopefully get you more bug reports early and we > can merge it in a more finished state for the 1.9 alpha. Agreed, especially the apps that we know are doing heavy customization like django-cms should provide some good leads to what we can do better. Jannis -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/7D748C5C-AAD7-405C-825B-AB33E91BF122%40gmail.com. For more options, visit https://groups.google.com/d/optout.
