Hi Yichun Duan, Thanks for submitting a proposal - what you've submitted is a good start, but it needs some more detail and clarification.
4.1: You say you're going to save the database-specific tests "to another place" - Can you give specifics, or at least an idea of you current thinking? How will that chosen location allow external database backends to provide tests? 4.1 (the second one): What backend specific tests are you proposing to write? We've got a fairly well tested code base; if there's a specific area where you think more tests are required, you should be explicit about the nature of those tests. 4.2: Isn't really true. We already have database specific tests, using the @skipUnless(connection.vendor == '...') decoration on tests. What were you thinking of introducing in this step? 4.3: If I understand this, You're allocating a week to *run* a test suite? This sounds... very well padded. Unless you've got something specific in mind, I would consider "running the test suite" to be just part of normal development, not something that requires a specific time allocation. 4.4: "Solve the database problem". Sorry, but this sounds like an "underpants gnome" answer: Step one - steal the underpants, Step two...... Step three Profit! It's not clear to this proposal that you've described a single problem, let alone proposed a solution that can clearly be implemented in 2 weeks. 4.5: What constitutes a "more complex environment"? You either have a MySQL database, or you don't. What "complexity" are you referring to? 4.6-4.8 are broadly Ok - having a couple of weeks for cleanup and extension tasks at the end of your project is a good idea. However, you've allocated 1/3 of your project time to "cleanup" tasks. That seems a little excessive. Item 4.4 is the biggest issue in my opinion. It feels like this is the real "meat" in your proposal, but it is not clear to me at all what you're planning to do here. You don't have to provide detailed specifics, and what you propose here may not end up being what is accepted -- but some broad architectural ideas would be very helpful. It would also be helpful to think about what you can provide as interim deliverables for this project. Ideally, the result of this project wouldn't be "one big PR at the end" - it would be much better to see a number of smaller pull requests. Smaller PRs are more likely to get merged, and reduce the need for any time allocation for merge tasks. Yours, Russ Magee %-) On Tue, Mar 17, 2015 at 8:31 PM, Yichun Duan <[email protected]> wrote: > I've written a draft proposal according to your idea. draft proposal > <https://github.com/friyal/proposal/blob/master/yichun-proposal-draft.md> > I'm looking forward for your feedback. Thank you for your help. > > 在 2015年3月16日星期一 UTC+8下午7:22:40，Shai Berger写道： > >> I can't answer for sure because there are still open issues there (e.g. >> what >> do you do in the face of multiple databases using different engines). But >> for >> the "clear cut" issues, my estimate is that they shouldn't take more than >> a >> few days. >> >> Shai. >> >> On Sunday 15 March 2015 14:03:44 Yichun Duan wrote: >> > And another question, how long will this task take in your opinion? I >> can >> > hardly estimate it now. >> > >> > 在 2015年3月15日星期日 UTC+8下午7:07:11，Shai Berger写道： >> > >> > > On Sunday 15 March 2015 03:45:16 Yichun Duan wrote: >> > > > Thank you. When you say "backend-provided tests", do you mean MySQL >> > > > scripts, Oracle scripts or something else like these? Or just some >> > > > tests based on django standard, which have marks to tell test >> runner >> > > > the >> > > >> > > backend >> > > >> > > > they suite? >> > > >> > > I mean standard Django tests, which are located in folders inside the >> > > backend >> > > source. That is, Oracle-specific tests in django.db.backends.oracle.tests >> >> > > etc. >> > > Today, the test-runner will not discover such tests and so will not >> run >> > > them >> > > even if the specific backend is in use. >> > > >> > > In the current Django test-suite, there are several tests marked to >> run >> > > only >> > > on a specific backend. I'd also like to remove them from there, and >> put >> > > them >> > > into the backends. That's the "clean-up". >> > > >> > > Shai. >> > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/1f8f91d1-e921-4dc7-9ac6-efc61f667660%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/1f8f91d1-e921-4dc7-9ac6-efc61f667660%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAJxq848rNvKyMyDGqC1KaD-OWoeO%2BMVyO5qCH3PB%2BopCKKdCAg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
