2015-03-11 21:20 GMT+01:00 elky <[email protected]>: > I reworked my previous attempt > <https://github.com/django/django/pull/4232> of stylizing django admin > and now it looks more like original in terms of color scheme. See > attachments. >
This looks good! Now let's try and see if we can merge it :-) Here are some questions that come to mind: 1) Roboto is licensed under the Apache License. I don't think we can simply distribute it under Django's BSD license. This can be solved in various ways but mustn't be forgotten. 2) I'm not sure how people will feel about shipping 320kB of fonts with Django. That's a few percent of Django's total size. That's better than using Google Fonts by default, though. 3) Did you test RTL? Just set your language to Hebrew (he), browse the admin and see if the layout breaks. 4) Did you test non-trivial cases — say, horizontal filter in a tabular inline? The easiest would be to have a few models and admins configured to use all admin options. People who develop custom admin skins need this; I would be surprised if this didn't exist already. 5) Did you test your design with some accessibility checking tool? If we're modernizing the admin, let's try to do this right. Jessica McKellar made some good points during her keynote at DjangoCon Europe 2012. Watch it at least skim Reinout van Rees' notes! I hope this helps, -- Aymeric. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CANE-7mUysAYk1GcDbuOQV_oGU2nqdnbf45o9BGRhcydTKwcAJw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
