> > Thanks for your continued work on this and sorry for my slow answers. >
No worries. I've been taking the time to get a better grasp of Django templates as a whole. > > Does that makes sense, or should I look for a way to incorporate that > > into LoaderOrigin? > > Looking at the implementation, it feels weird to add attributes to the > origin > that are only used by the loader… If origins were dumb bags of data this > would be all right but they have a reload() method that calls the loader. > > Such mutual dependencies never end well :-/ That’s a broader design > problem not directly related to your refactoring, but while you’re > breaking > all the things, perhaps we could fix it too. > Yes. I'll look at this. The reload method isn't documented and I think it can go away if the debug view is updated. > By the way, I would like to check if we can deprecate the dirs argument of > LoaderOrigin. It may only be used by deprecated code as of Django 1.8. > Deprecate or remove? :) This argument is one I don't think is documented anywhere. > In fact context.template.engine would be much better than context.engine. > I’ll try > to fix that in 1.8 before it’s too late. Sure. I forgot to mention it but my latest patch actually solves this by passing origin in context.render_context. This makes sense because render_context is available only in the current render scope, rather than modifying the global context. I'm just as happy with accessing context.template, though. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/a9a02345-feb9-4d5e-b14c-09e61ae386e4%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
