Thanks for the suggestion, Jelena. I'd be happy to look at a patch, although my initial instinct is that while there is some duplication, adding a method might actually created unneeded complexity and make things somewhat less readable. Feel free to send a pull request if you take a stab at it and think that it's an improvement.
On Friday, October 3, 2014 4:47:29 PM UTC-4, Jelena Kutalovskaja wrote: > > Hello, > > what do You think about response_change method in > django/contrib/options.py (master)? Maybe this place must be refactored? > The code here is pretty much the same, so we can create one method and run > each if/elif through it. > > Jelena > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/87e9e610-5911-4a2d-8f5b-ce2e764767e0%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
