Sounds like a good idea Miguel, please open a ticket or send a pull request that references the original ticket.
Just wanted to clarify that the commit you referenced will be part of Django 1.7, not 1.6. On Tuesday, November 5, 2013 11:10:01 AM UTC-5, Miguel Araujo Pérez wrote: > > Hi there, > > Django 1.6 changes the key name that is used to store the language > preferred by the user, due to the new name policies. This commit introduced > it: > > https://github.com/django/django/commit/0d0f4f020afe516f23fd2305f13ff0a6a539b344 > > If you look at > `django.views.i18n.set_language`<https://github.com/django/django/blob/master/django/views/i18n.py#L38>you > will see that `'_language'` is now used, when in django 1.5 used to be > `'django_language'`. > > In my humble opinion this key should be a variable that could be imported > from the outside. We currently have the following use case: > > We let an anonymous user set a language for the page, and when the user > logs in, we keep the language around in session to continue rendering the > web in the same language. This change in the key name breaks our book > keeping, because we are using a hardcoded string (we only keep that key, > not all of them). > > Thanks, cheers > Miguel Araujo > > > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/490084b9-b267-496c-8947-da320d012fc4%40googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
