I'm not sure that's really sensible style, tho - classes that are intended
to be used as mixins should call super, and the base class should be the
last in the hierarchy.
class FooMixin(object):
def __init__(self):
super(FooMixin, self).__init__()
self.foo = 3
class MyModel(FooMixin, models.Model):
pass
Am I missing some useful case where it's necessary for a mixin class to be
used as the base class rather than a super class?
On Sunday, 29 September 2013 18:01:38 UTC+1, Alex_Gaynor wrote:
>
> It matters if you're going to mixin a class whose common ancestor is
> object, e.g.:
>
> class FooMixin(object):
> def __init__(self):
> self.foo = 3
>
> class MyModel(models.Model, FooMixin):
> pass
>
> if models.Model.__init__ doesn't call super().__init__, then
> FooMixin.__init__ won't be invoked.
>
> Alex
>
>
> On Sun, Sep 29, 2013 at 10:00 AM, Tom Christie
> <[email protected]<javascript:>
> > wrote:
>
>> Calling super in base classes (ie anything that inherits from 'object')
>> just seems unnecessary and obscure to me. It's not a pattern I use or have
>> seen, and after playing around a bit I can't see any sensible case where
>> it'd make a difference. `View` should always be the last (right-most)
>> class in hierarchy, so there shouldn't ever be any parent behaviour that
>> needs calling into.
>>
>>
>> On Saturday, 28 September 2013 13:34:23 UTC+1, Daniele Procida wrote:
>>>
>>> <https://code.djangoproject.**com/ticket/21111<https://code.djangoproject.com/ticket/21111>>
>>>
>>>
>>>
>>> There's some discussion of a particular class, django.views.base.View,
>>> and whether its __init__() should contain a super(View, self).__init__().
>>>
>>> But there's also a wider question of whether there should be a general
>>> rule about this, whether the integrity of the __init__() chain should be
>>> maintained, and whether it matters that not all of our classes that are
>>> likely to be subclassed do it.
>>>
>>> Any comments?
>>>
>>> Daniele
>>>
>>> --
>> You received this message because you are subscribed to the Google Groups
>> "Django developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to [email protected] <javascript:>.
>> To post to this group, send email to
>> [email protected]<javascript:>
>> .
>> Visit this group at http://groups.google.com/group/django-developers.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>
>
>
> --
> "I disapprove of what you say, but I will defend to the death your right
> to say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
> "The people's good is the highest law." -- Cicero
> GPG Key fingerprint: 125F 5C67 DFE9 4084
>
--
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/django-developers.
For more options, visit https://groups.google.com/groups/opt_out.
